Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test GitHub workflow #7

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Add test GitHub workflow #7

merged 2 commits into from
Sep 1, 2024

Conversation

TokenRat
Copy link
Collaborator

This adds a test-workflow that tests compiling

This adds a test-workflow that tests compiling
@TokenRat
Copy link
Collaborator Author

I have a 'release' workflow as well. But I want to test it on a fork, which I can only do once the repo is public.

So adding the test workflow for now is nice.

@TokenRat TokenRat changed the title Draft: Add GitHub workflows Add GitHub workflows Aug 28, 2024
@TokenRat TokenRat changed the title Add GitHub workflows Add test GitHub workflow Aug 28, 2024
@ngandrass
Copy link
Collaborator

Looks good. But do we want to run the CI job for all pushes on feature branches? Or do we want to limit it to main, develop and PRs?

@ngandrass ngandrass changed the base branch from main to develop August 28, 2024 18:12
@TokenRat
Copy link
Collaborator Author

main and PRs only. Which is 99% of all commits. But yes, let me sharpen the rules there.

But the only reason I see not to do this, is that it might eat EF's free runner minutes. But I just talked with Flam: They are hardly used and if it gets low, we will buy some more. So that is also fine.

As long as the cache works, I think we should use it.

@TokenRat TokenRat merged commit a972939 into develop Sep 1, 2024
1 check passed
@TokenRat TokenRat deleted the feature/ci_test branch September 1, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants